search

microsoft / hummingbird

Hummingbird compiles trained ML models into tensor computation for faster inference.
MIT License
3.32k stars 274 forks source link

ONNXMLGather breaks tests #744

Closed ksaur closed 6 months ago

ksaur commented 6 months ago

failed runner

todo investigate: ValueError: Unsupported conversion for operator ONNXMLGather

=========================== short test summary info ===========================
FAILED tests/test_backends.py::TestBackends::test_onnx_no_test_data_int - ValueError: Unsupported conversion for operator ONNXMLGather
FAILED tests/test_onnxml_one_hot_encoder_converter.py::TestONNXOneHotEncoder::test_model_one_hot_encoder_string - ValueError: Unsupported conversion for operator ONNXMLGather
FAILED tests/test_onnxml_one_hot_encoder_converter.py::TestONNXOneHotEncoder::test_one_hot_encoder_onnx2 - ValueError: Unsupported conversion for operator ONNXMLGather
FAILED tests/test_onnxml_one_hot_encoder_converter.py::TestONNXOneHotEncoder::test_one_hot_encoder_onnx_int - ValueError: Unsupported conversion for operator ONNXMLGather
FAILED tests/test_onnxml_one_hot_encoder_converter.py::TestONNXOneHotEncoder::test_one_hot_encoder_onnx_int64 - ValueError: Unsupported conversion for operator ONNXMLGather
==== 5 failed, 530 passed, 105 skipped, 223 warnings in 309.38s (0:05:09) =====
ksaur commented 6 months ago

Old:

Collecting skl2onnx>=1.7.0
  Downloading skl2onnx-1.15.0-py2.py3-none-any.whl.metadata (2.3 kB)

New:

Collecting skl2onnx>=1.7.0
  Downloading skl2onnx-1.16.0-py2.py3-none-any.whl.metadata (3.2 kB)
ksaur commented 6 months ago

It appears that ArrayFeatureAbstractor was changed to Gather in https://github.com/onnx/sklearn-onnx/commit/262abfc78b0079d1f2eb8113bfbf67abd50b1bd3