search

microsoft / hummingbird

Hummingbird compiles trained ML models into tensor computation for faster inference.
MIT License
3.32k stars 274 forks source link

Unpinning xgboost version #745

Open mshr-h opened 6 months ago

mshr-h commented 6 months ago

Fix #732 Seems like 1.12.0 has the fix?

ksaur commented 6 months ago

Thanks! It should, but we need to first fix #744. My goal is to patch by end of week!

ksaur commented 6 months ago

please rebase and hopefully it works! :)

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (94ce98c) 90.25% compared to head (58dadc2) 90.25%.

:exclamation: Current head 58dadc2 differs from pull request most recent head 27d2112. Consider uploading reports for the commit 27d2112 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #745 +/- ## ======================================= Coverage 90.25% 90.25% ======================================= Files 80 80 Lines 4677 4677 Branches 856 856 ======================================= Hits 4221 4221 Misses 259 259 Partials 197 197 ``` | [Flag](https://app.codecov.io/gh/microsoft/hummingbird/pull/745/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/microsoft/hummingbird/pull/745/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `90.25% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.