Closed apoorvedave1 closed 3 years ago
Linux and Windows have different notions of end of line (CRLF vs LF, \r\n vs \n) which causes gold standard tests to fail when the golden file is created on one setup and tested on another.
Remove linefeeds before comparing plans.
no
https://github.com/microsoft/hyperspace/pull/376 sanity check will be added to build process and will start passing for windows.
LGTM thanks!
sezruby
commented
3 years ago
What is the context for this pull request?
Linux and Windows have different notions of end of line (CRLF vs LF, \r\n vs \n) which causes gold standard tests to fail when the golden file is created on one setup and tested on another.
What changes were proposed in this pull request?
Remove linefeeds before comparing plans.
Does this PR introduce any user-facing change?
no
How was this patch tested?
https://github.com/microsoft/hyperspace/pull/376 sanity check will be added to build process and will start passing for windows.