search

microsoft / hyperspace

An open source indexing subsystem that brings index-based query acceleration to Apache Spark™ and big data workloads.
https://aka.ms/hyperspace
Apache License 2.0
424 stars 115 forks source link

Fix sbt-launch-lib.bash #436

Closed imback82 closed 3 years ago

imback82 commented 3 years ago

What is the context for this pull request?

After #421, sbt-launch-lib.bash is broken, and we need to update the url to fetch sbt-launcher-*.jar from. Current it fails with:

09:36 $ ./build/sbt
Attempting to fetch sbt
Our attempt to download sbt locally to build/sbt-launch-1.5.0.jar failed. Please install sbt manually from http://www.scala-sbt.org/

What changes were proposed in this pull request?

Fix the url to fetch sbt-launcher.jar from.

Does this PR introduce any user-facing change?

Yes, now ./build/sbt works fine.

How was this patch tested?

Tested manually

clee704 commented 3 years ago

What's the purpose of these scripts?

imback82 commented 3 years ago

https://www.scala-sbt.org/1.x/docs/Launcher-Getting-Started.html#:~:text=The%20sbt%20launcher%20component%20is%20a%20self-contained%20jar,and%20a%20Java%20runtime%20version%201.6%20or%20greater. Basically you don't need to install sbt manually. You can just clone this repo and do ./build/sbt to get started (unfortunately only on *nix for now).