Fix StructType serialization - Githubissues

microsoft / hyperspace

An open source indexing subsystem that brings index-based query acceleration to Apache Spark™ and big data workloads.

https://aka.ms/hyperspace

Apache License 2.0

424 stars 115 forks source link

Fix StructType serialization #459

Closed clee704 closed 3 years ago

clee704 commented 3 years ago

What is the context for this pull request?

Tracking Issue: N/A
Parent Issue: N/A
Dependencies: N/A

What changes were proposed in this pull request?

Follow-up of #443.

Fix StructType serialization issue on the object mapper level.
Remove annotations previously used to fix the issue.
Change Relation.dataSchemaJson: String to Relation.dataSchema: StructType.

Does this PR introduce any user-facing change?

Yes, the serialization format of IndexLogEntry is changed. Note that #443 already changed this, so this is not a new breaking change.

How was this patch tested?

With existing tests.

andrei-ionescu commented 3 years ago

LGTM, just curious as @imback82 is curious, why not doing the same on the 3.x version?

sezruby commented 3 years ago

LGTM thanks! Please address @imback82 's comments