microsoft / igvm

MIT License
81 stars 17 forks source link

snp_defs: add missing fields for `SevFeatures` #54

Closed 00xc closed 1 month ago

00xc commented 1 month ago

Add several missing bits for SevFeatures:

chris-oo commented 1 month ago

other than the small nit, change looks fine to me! Thanks for your contribution!

00xc commented 1 month ago

@microsoft-github-policy-service agree [company="SUSE"]

00xc commented 1 month ago

@microsoft-github-policy-service agree company="SUSE"

00xc commented 1 month ago

@chris-oo updated with your suggestion

chris-oo commented 1 month ago

Thanks! I've gone ahead and enabled automerge. Do you need a release on crates.io with this change?

00xc commented 1 month ago

Thanks! I've gone ahead and enabled automerge. Do you need a release on crates.io with this change?

I think at some point we will want this but it's not urgent, so I'd say not for now.