microsoft / iis-docker

Dockerfile for IIS
https://hub.docker.com/r/microsoft/iis/
MIT License
288 stars 128 forks source link

IIS Servicemonitor crashes when %18 is used in environment variable #188

Closed erenes closed 5 months ago

erenes commented 3 years ago

The IIS servicemonitor and therefore our containers crash if the environment variable contain a %## sequence that resolve to an invalid XML character when URL encoded.

Steps to reproduce:

  1. docker run -p80:80 -e TEST="%18" mcr.microsoft.com/windows/servercore/iis

Expected: Image runs and I can access an IIS test page on http://localhost Actual: Image runs and immediately crashes.

PS C:\Temp\docker\iis> docker run -p80:80 -e TEST="%18" mcr.microsoft.com/windows/servercore/iis

 Service 'w3svc' has been stopped

APPCMD failed with error code -1072894421

Failed to update IIS configuration

Suggested fix: Update the IIS Monitor with this PR: https://github.com/microsoft/IIS.ServiceMonitor/pull/72

Previously reported in August 2020: https://github.com/microsoft/IIS.ServiceMonitor/issues/71

erenes commented 5 months ago

Hi @John-Hart, thanks for looking into the issue!

Since it was marked complete, I thought I would try again with my current laptop, but it appears that the problem has not been resolved in the released version of the image:

❯ docker run -p8000:80 -e TEST="%18" mcr.microsoft.com/windows/servercore/iis

Stopping service 'w3svc'

 Service 'w3svc' has been stopped

APPCMD failed with error code -1072894421

Failed to update IIS configuration

I am currently using Windows 10 22H2 (19045.4170), if that makes a difference.

Assuming that this was not closed by mistake, is there an ETA for the updated version of the image to be released?

John-Hart commented 5 months ago

This was closed as part of a bulk cleanup of very old issues to get to a manageable state. It was not fixed. If you feel this issue is still a blocking issue please feel free to open a new issue and we can prioritize it.