search

microsoft / inshellisense

IDE style command line auto complete
MIT License
8.22k stars 180 forks source link

fix: support new version autocomplete #153

Closed alanhe421 closed 4 months ago

alanhe421 commented 5 months ago

I submitted this PR, but there are a few points that I'm uncertain about and need to discuss:

  1. Do we need to lock the version of @withfig/autocomplete or revert it back to the previous ^? We previously locked the version because the new updates from fig caused user startup errors. I locked the version as a temporary solution. Since I have now fixed the error caused by the loading standards, I upgraded the package version. If we decide to revert to ^, I will need to make another change. The advantage of locking the version is that we don't have to worry about fig updates causing unexpected errors in our implementation, but the downside is that we need to continually update it.

    image

  2. The reason for the error when installing new versions of @withfig/autocomplete, such as v2.651.0, is that it provided specifications with certain information that led to errors. Firstly, I think this is unreasonable, and I understand it to be an issue with the Fig autocomplete package. However, for the inshellisense project, I believe we can improve robustness to prevent the unreasonableness of a single specification from causing errors in the overall load.

    image image
alanhe421 commented 5 months ago

@cpendery Hi, Can you review this modification?

cpendery commented 4 months ago

@alanhg there are definitely more improvements to make on the runtime. These changes aren't breaking for fig's runtime, so hopefully we can get to a point of equivalent implementation. I'll be working on adding a much more robust test suite as we push towards 0.0.1