search

microsoft / inshellisense

IDE style command line auto complete
MIT License
8.39k stars 186 forks source link

ci: add matrix for command #30

Closed manudeli closed 11 months ago

manudeli commented 11 months ago

I added matrix for command to reduce ci time

cpendery commented 11 months ago

Hi @manudeli, I really appreciate the PR, but I'm not sure spinning out a different job for linting vs testing is the best approach since I'll already be using an additional 9 checks for E2E testing across node 16,18,20 across windows, mac, and linux

manudeli commented 11 months ago

I understand your concern that the number of actions might become too large. However, I think it's okay to easily merge this Pull Request and add window, mac, and linux later and fix it again if there are any problems. How about proceeding like this?

cpendery commented 11 months ago

I understand your concern that the number of actions might become too large. However, I think it's okay to easily merge this Pull Request and add window, mac, and linux later and fix it again if there are any problems. How about proceeding like this?

While I agree merging it would be okay, I'm still not sure the change makes sense for the 2-3 second speed up. I'm going to close the PR we can reopen it in the future if the build times become a problem.