microsoft / inshellisense

IDE style command line auto complete
MIT License
8.24k stars 181 forks source link

Add troubleshooting steps for bind command issues #31 #34

Closed pkvijay65 closed 8 months ago

pkvijay65 commented 8 months ago

Fix for Shell Binding Issue on Non-PowerShell Environments

This PR addresses an issue where inshellisense attempts to spawn a PowerShell process in environments where PowerShell may not be available or necessary, such as when a user is operating within zsh or other non-PowerShell shells.

Fixes #31 #19

Changes Made

Testing The fix has been tested on macOS with oh my zsh, ensuring that inshellisense bind operates without trying to spawn PowerShell and binds the desired key successfully.

pkvijay65 commented 8 months ago

@microsoft-github-policy-service agree

Delta456 commented 8 months ago

I think the bind command must check the OS first before binding.

pkvijay65 commented 8 months ago

yes, @Delta456, this is what I am figuring out in source code. For now the temporary workaround fix should help this project reach more developers for trial.

goutamtadi1 commented 8 months ago

Despite installing the powershell, I still see the error. I installed powershell using brew install powershell/tap/powershell image

Dima-Kal commented 8 months ago

The fix has been tested on macOS with oh my zsh

I wouldn't consider this a fix, loading inshellisense with "inshellisense --shell zsh" loads zshell without the profile beating the whole purpose of OMZ

cpendery commented 8 months ago

I believe #31 was already fixed by #29. For #19, the issue is that the shell prompt isn't loading properly when running is -s zsh because I intentionally only execute via a subshell. I'm investigating a re-design of the runtime to support this case, so I don't think we need this change to the documentation

cpendery commented 8 months ago

Despite installing the powershell, I still see the error. I installed powershell using brew install powershell/tap/powershell image

powershell refers to Windows Powershell rather than pwsh which is what you are installing via brew. Try out 0.0.1-rc.3 once it's released and this should be resolved @goutamtadi1

pkvijay65 commented 8 months ago

Understood. thanks for the feedback. Closing this PR.