microsoft / iomt-fhir

iomt-fhir
MIT License
146 stars 68 forks source link

Consolidate code between OSS and PaaS #251

Closed wi-y closed 1 year ago

wi-y commented 2 years ago

This PR migrates some PaaS classes into OSS, and attempts to consolidate the startup classes (and code) between OSS and PaaS. Previously there was one startup class in OSS for both normalization and fhirtransformation. Now, there is one startup class for normalization and one startup class for fhirtransformation which aligns with PaaS. These startup classes will be consumed in PaaS and can be subclassed if needed.

The only differences in PaaS should be:

For this iteration we are adding classes. Once we migrate to these new classes (nuget packages) in PaaS we will deprecate the code in .\iomt-fhir\src\console\Microsoft.Health.Fhir.Ingest.Console.csproj which will be no longer be needed.

One additional call out for OSS is that we are now using ResumableEventProcessor so that we can align on one event processor but in OSS we are not using any healthchecks. If we feel that the healthchecks should be migrated to OSS then I am open to that.