search

microsoft / iot-cardboard-js

iot-cardboard-js is a React library for building experiences for IoT applications
https://main--601c6b2fcd385c002100f14c.chromatic.com/
MIT License
84 stars 26 forks source link

tsiclient/UXClient direct import bloating package size #24

Closed ccrowley96 closed 3 years ago

ccrowley96 commented 3 years ago

https://github.com/microsoft/iot-cardboard-js/blob/main/src/Adapters/TsiAdapter.ts#L3

transformTsqResultsForVisualization call requires UXClient import which also imports a lot of other modules - including Azure maps dependency.

It looks like this increases package size by >1MB.

I think the best fix here is to move helper functions like transformTsqResultsForVisualization outside of 'tsiclient/UXClient'

ccrowley96 commented 3 years ago

transformTsqResultsForVisualization direct import