Data pusher fix duplication in URL

pasanchMSFT commented 1 year ago

Summary of changes 🔍

Fixes duplication created by setting a baseURL in the axios instance used for data pusher requests. URL is now managed by generateURL function exclusively.

this.axiosInstance can only be found in the following methods of ADT Adapter:

createModels (only found in GenerateADTAssets.tsx a data pusher component)
createTwins (only found in GenerateADTAssets.tsx a data pusher component)
createRelationships (only found in GenerateADTAssets.tsx a data pusher component)

Testing 🧪

Try out data pusher stories locally with both CORS on and off.

Checklist ✔️

[ ] Linked associated issue (if present)
[ ] Added relevant labels
[ ] Requested developer reviews
[ ] Request UI review from design / PM
[ ] Verify all code checks are passing

msnyder-msft commented 1 year ago

we have had several point fix PRs. How are we doing validations to ensure we don't need more fixes like this?

pasanchMSFT commented 1 year ago

we have had several point fix PRs. How are we doing validations to ensure we don't need more fixes like this?

Basically running scenarios manually, would be useful to have testing for these adapter methods but currently we don't have that in place.

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 1.0.0-beta.389 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

microsoft / iot-cardboard-js