microsoft / iot-cardboard-js

iot-cardboard-js is a React library for building experiences for IoT applications
https://main--601c6b2fcd385c002100f14c.chromatic.com/
MIT License
84 stars 27 forks source link

[Data History Widget]: Label fix in "View" mode #961

Closed iremgokce closed 1 year ago

iremgokce commented 1 year ago

Summary of changes ๐Ÿ”

Fixed series id inconsistency with fetched data due to creating a new guid in component lifecycle. It was a bug reported by a customer by not seeing the label of time series correctly in a data history widget in view mode. As a fix, I set the seriesId of the time series to the id of the data history time series in the 3d config file for consistent id mapping:

image

image

with fix:

image

image

Testing ๐Ÿงช

You can test it by creating a data history widget with a time series with a label and see it in View mode using ADT3DScenePage story.

Checklist โœ”๏ธ

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 1.0.0-beta.396 :tada:

The release is available on:

Your semantic-release bot :package::rocket: