microsoft / iot-cardboard-js

iot-cardboard-js is a React library for building experiences for IoT applications
https://main--601c6b2fcd385c002100f14c.chromatic.com/
MIT License
84 stars 26 forks source link

feat: Build with node 16 + get off of node-sass #974

Closed msnyder-msft closed 5 months ago

msnyder-msft commented 9 months ago

Summary of changes ๐Ÿ”

Node-sass is deprecated, and is what was pinning us to Node 14 (which is also deprecated) so we will get off of node-sass using Dart-Sass which will free us up to get to node 16 which is currently in LTS. Dart-sass exposes the same JS API so it's a drop-in replacement.

Migrated our node-sass command line to dart-sass command line - docs

Note: NPM package install started failing with a conflicting peer dependency if we go to node 18, so postponing that migration for another time.

Testing ๐Ÿงช

msnyder-msft commented 9 months ago

When we try to get to node 18 we get stuck with this failure and it's been a rabbit hole. image

rapotl commented 5 months ago

Testing ๐Ÿงช

3DScenes: 3dScenes-eot

github-actions[bot] commented 5 months ago

:tada: This PR is included in version 1.0.0-beta.404 :tada:

The release is available on:

Your semantic-release bot :package::rocket: