search

microsoft / jacdac

Device and service catalogs for Jacdac.
https://aka.ms/jacdac
Creative Commons Attribution 4.0 International
66 stars 25 forks source link

when registering a new device in the catalog, the import function doesn't seem to work right #1232

Closed sehodges closed 1 year ago

sehodges commented 1 year ago

Starting from the device registration page, I click on 'import'. But for the modules I tried (e.g. RP2040 brain 124 V1.3 running Jacscript firmware, and the triple sliders) the text that appears in the device name field seems to miss the first character and the text that goes into the company field is also filled in as the device name.

Here are some screenshots:

image

image

pelikhan commented 1 year ago

It is a best effort to parse the company name from the description. The user needs to patch.

sehodges commented 1 year ago

But there's just an off-by-one error? It's probably better to have no auto-suggest than something that's wrong every time?

sehodges commented 1 year ago

Sorry, to be clear: website suggests R2040 instead or RP2040 and M-slider-3 instead of JM-slider-3. The auto-suggest for the company name gets the device name correct, can we just use the code from there to replace what you currently have for the device name?

If you want to delete the auto-suggest for the company name (since the current heuristic seems to fail and get the device name) that's fine with me.

tballmsft commented 1 year ago

Seems like a bug here.

pelikhan commented 1 year ago

heuristic removed