microsoft / jacdac

Device and service catalogs for Jacdac.
https://aka.ms/jacdac
Creative Commons Attribution 4.0 International
66 stars 24 forks source link

led strip(RGB Strip) can't be turned off in Makecode #1319

Closed smfox10 closed 8 months ago

smfox10 commented 10 months ago

No response occurs when pressing both buttons A and B

https://makecode.microbit.org/_VuJHtFacrbWW image

Also I can't turn off the led strip by setting the brightness. https://makecode.microbit.org/_ViqWCcViWMi5 image

https://github.com/microsoft/jacdac/assets/3880290/b8f21961-23dc-46e3-af2f-fa5598cea638

smfox10 commented 10 months ago

Problems still exist

pelikhan commented 10 months ago

The rendering update was skipped when setting all pixels to 0... In which case MakeCode actually turns off the power on the strip.

pelikhan commented 10 months ago

https://github.com/microsoft/jacdac-ts/compare/d5dc3fb56a443226222f3dea9af3c1fcc5363753...506c1e39c52b7204c87cfa861c7e6012a43e9fa3#diff-292eb7d73cbeac6600b5f2a4688e0d3b3a32c1e6ce767bff7f52d1ed20913a97

pelikhan commented 10 months ago

First issue is fixed, working on brightness.

pelikhan commented 10 months ago

Better brightness support https://github.com/microsoft/jacdac-docs/commit/2d8fd72ed159b4d26023c352e76764636b08c875

smfox10 commented 8 months ago

@xmeow

smfox10 commented 8 months ago

https://makecode.microbit.org/_41gU7V35V1gs

smfox10 commented 8 months ago

@xmeow

https://github.com/microsoft/jacdac/assets/3880290/38cecd2e-ecff-4649-92c5-8b61e64932d9

pelikhan commented 8 months ago

Can you turn it off through the dashboard?