microsoft / jacdac

Device and service catalogs for Jacdac.
https://aka.ms/jacdac
Creative Commons Attribution 4.0 International
66 stars 25 forks source link

Kittenbot Jacdac-Power module (Kit B) is displayed twice as UE21 and KA82 #1345

Closed fabianhugo closed 8 months ago

fabianhugo commented 9 months ago

Describe the bug A brief search did not show a duplicate issue. Kittenbot Jacdac-Power module (Kit B) is displayed twice as UE21 and KA82 in the Jacdac Dashboard: grafik

In makecode.microbit.org the power module is not displayed below the simulator.

To Reproduce

  1. Flash Jacdac firmware to microbit
  2. Go to jacdac dashboard
  3. Connect power module
  4. Power module appears twice as UE21 and KA82

Expected behavior Only one instance of the power module should be shown.

pelikhan commented 9 months ago

@fabianhugo could you attach the packet trace?

fabianhugo commented 9 months ago

Sure. In this trace I connected the power module after a couple of seconds and unplugged it a couple of seconds later. trace_power.jd.txt

pelikhan commented 9 months ago

@xmeow @smfox10 please take a look

xmeow commented 9 months ago

@fabianhugo Thank you for the feedback. Actually there is two separate power supply controllers on the module as discussed here: https://github.com/microsoft/jacdac/discussions/373 But only one should be working at same time if there is external wiring to connect the two power supply together.

smfox10 commented 9 months ago

@fabianhugo On the Jacdac platform, there are two Jacdac power modules displayed (you can see two PADAUK ICs), which is not a bug. They are responsible for controlling the power on/off of the two Jacdac interface channels.

On the Makecode platform, the power module is not displayed. This decision was made in communication with Peli. Since Makecode platform programming is simple and there is no need to turn off the module, the power is generally kept on. Therefore, the icon was hidden.

pelikhan commented 9 months ago

I will add a note on the device page. It seemed like a good idea to hide them... but we could revisit this decision.

fabianhugo commented 8 months ago

That sounds interesting. So each displayed jacdac module allows the control of one voltage source? From my perspective, it would be nice to have some visual feedback in makecode as well for the voltage source to be supplying the bus, without a switch. But I'd see that as a feature with low level priority. Thanks for the answers, from my side this issue can be closed.

pelikhan commented 8 months ago

Fixed by https://github.com/microsoft/jacdac-docs/pull/280