search

microsoft / jacdac

Device and service catalogs for Jacdac.
https://aka.ms/jacdac
Creative Commons Attribution 4.0 International
66 stars 25 forks source link

unique names in specifications #339

Closed tballmsft closed 3 years ago

tballmsft commented 3 years ago

Currently, names in specifications are divided up by packet types, so it is possible for a register and event to have the same name. I propose that we disallow multiples uses of same name in a specification to reduce change for confusion.

pelikhan commented 3 years ago

@mmoskal this seem like a good idea

mmoskal commented 3 years ago

yes; I'll do it next time I get to the spectool unless someone beats me to it ;)

pelikhan commented 3 years ago

lemme take a look

pelikhan commented 3 years ago

Seems thiat this is already being done.

pelikhan commented 3 years ago

https://github.com/microsoft/jacdac/blob/fcecddd951984fb4839ffc486d2f19070c5ccad4/spectool/jdspec.ts#L585