search

microsoft / jacdac

Device and service catalogs for Jacdac.
https://aka.ms/jacdac
Creative Commons Attribution 4.0 International
66 stars 25 forks source link

Handle MakeCode Arcade + micro:bit in pxt-jacdac #344

Closed jamesadevine closed 3 years ago

jamesadevine commented 3 years ago

https://github.com/microsoft/pxt-jacdac/blob/master/hw.cpp#L194

The extension does not currently work as is in Arcade. This is because #ifdef MICROBIT_CODAL is never true because MICROBIT_CODAL is not defined in arcade.

mmoskal commented 3 years ago

Well that is by design, since there is no uBit object in Arcade. We need to add:

namespace config {
    export const PIN_JACK_TX = DAL.P0_12
}

to n3/config.ts in Arcade. For the time being, you can add it to your program.

jamesadevine commented 3 years ago

Yup, I know. Was just making an issue for it

pelikhan commented 3 years ago

@mmoskal can i assign this to you?

mmoskal commented 3 years ago

@jamesadevine can you test this build https://arcade.makecode.com/app/e8fb53191ad1fa21997a58a8dcc1469218fe2f0c-c92e15dd3e ? I don't have arcade shield with JD handy

pelikhan commented 3 years ago

I pushed this fix to beta as well.

jamesadevine commented 3 years ago

@jamesadevine can you test this build https://arcade.makecode.com/app/e8fb53191ad1fa21997a58a8dcc1469218fe2f0c-c92e15dd3e ? I don't have arcade shield with JD handy

Yes! Works perfectly!

arcade-jacdac.zip