Refactor ReactParameterField file to not duplicate ReactInlineField

microsoft / jacdac

Device and service catalogs for Jacdac.

https://aka.ms/jacdac

Creative Commons Attribution 4.0 International

66 stars 25 forks source link

Refactor ReactParameterField file to not duplicate ReactInlineField #546

Closed rwilliams-msr closed 3 years ago

rwilliams-msr commented 3 years ago

Describe the bug The ReactParameterField file is a near duplicate of the ReactInlineField file, except that the former includes type. This is redundant and the code should be reworked to merge the two.

To Reproduce On modelblocks branch, view files in jacdac-docs/src/components/blockly/fields

Expected behavior Merge the files to remove redundant code

rwilliams-msr commented 3 years ago

Fixed this. Removed ReactParameterField