search

microsoft / jacdac

Device and service catalogs for Jacdac.
https://aka.ms/jacdac
Creative Commons Attribution 4.0 International
66 stars 25 forks source link

rename 'dummy' directory to 'hal' #63

Closed tballmsft closed 3 years ago

tballmsft commented 3 years ago

the files in the "dummy" directory of "interfaces" really represent the hardware abstraction layer that JD relies on. Can we use a different name than "dummy"? Perhaps "hal"?

jamesadevine commented 3 years ago

Are we supposed to be filing issues for other repositories here?

jamesadevine commented 3 years ago

I assume this is intended for jacdac-c?

tballmsft commented 3 years ago

Yes, this is for jacdac-c (and anywhere the structure is mirrored). Adding @pelikhan, @mmoskal. James, I think we should use one repo to collect issues, as much as possible.

jamesadevine commented 3 years ago

Sure, no problem with consolidation. Can we please use labels to indicate the affected repos? I had to check whether jacdac-ts had dummy interfaces.

jamesadevine commented 3 years ago

@tballmsft jacdac-c is designed so that developers can pick and choose the parts of jacdac-c relevant to them. To resolve compiler errors caused by only partially including jacdac-c, the library provides dummy implementations that have no functionality. Happy to change to a term that sounds better than dummy though :smile:

pelikhan commented 3 years ago

Rename it "template" and add TODOs in each funciton that needs to be implemented.

pelikhan commented 3 years ago

Or "platform", "hal" is a bit too mysterious for me.

mmoskal commented 3 years ago

"hal" is a common term in embedded and systems development