problem with MakeCode AccelerometerClient

[tballmsft]

1. compile and flash microbit-machine (which now has following code):

machine.addClientFactory(jacdac.SRV_ACCELEROMETER, devid => {
    const client = new modules.AccelerometerClient(devid)
    client.onFaceDown(() => basic.showIcon(IconNames.Sad,0))
    client.onFaceUp(() => basic.showIcon(IconNames.Happy,0))
    client.onTiltLeft(() => basic.showArrow(ArrowNames.West))
    client.onTiltRight(() => basic.showArrow(ArrowNames.East))
    client.onTiltUp(() => basic.showArrow(ArrowNames.North))
    client.onTiltDown(() => basic.showArrow(ArrowNames.South))
})

2. add physical accelerometer module,
3. note that nothing happens (micro:bit screen doesn't change on accel events)
4. connect to dashboard, now notice that micro:bit does respond
5. disconnect from dashboard and see that micro:bit doesn't respond to accel events

[tballmsft]

@pelikhan - are you able to repro this?

[pelikhan]

Not investigated yet

[tballmsft]

starting into it... first question - why are we using control.onEvent in pxt-jacdac/routing.ts for dealing with Jacdac events?

        protected registerEvent(value: number, handler: () => void) {
            this.start()
            control.onEvent(this.eventId, value, handler)
        }

[pelikhan]

this predates adding event source support in jacdac base types. The trouble with dynamic clients is that we leak those handlers.

[tballmsft]

Works now: @pelikhan - did you do something to address this?

[tballmsft]

Now, doesn't work... race condition?