Add is_fully_supported as a property of FroztEnv

microsoft / jericho

A learning environment for man-made Interactive Fiction games.

GNU General Public License v2.0

257 stars 42 forks source link

Add is_fully_supported as a property of FroztEnv #19

Closed MarcCote closed 4 years ago

MarcCote commented 4 years ago

The class method is_fully_supported was removed from FrotzEnv because of "side-effects". This PR proposes to add that information back as a property instead.

Motivation: TextWorld uses that information to know what information can be retrieved from a Jericho.FrotzEnv object.

MarcCote commented 4 years ago

@mhauskn let me know if you want to discuss this first.

MarcCote commented 4 years ago

@mhauskn can you ping me when you have pushed the new version to pypi? Thanks.

mhauskn commented 4 years ago

Just uploaded. It may take a few minutes before it syncs.

Sorry for not responding to the PR earlier - I think I don't get notifications unless you directly mention me.