search

microsoft / jericho

A learning environment for man-made Interactive Fiction games.
GNU General Public License v2.0
253 stars 42 forks source link

Null deference #27

Closed QiAnXinCodeSafe closed 4 years ago

QiAnXinCodeSafe commented 4 years ago

There is no check for the failed malloc

https://github.com/microsoft/jericho/blob/c58e987ede93f36738f547a734465f67bd61e273/frotz/src/blorb/blorblib.c#L104 This in turn would cause a segfault， when buff is dereferenced https://github.com/microsoft/jericho/blob/c58e987ede93f36738f547a734465f67bd61e273/frotz/src/blorb/blorblib.c#L129

mhauskn commented 4 years ago

The blorblib is not used as none of the Jericho supported games are in blorb format.