Fix type errors against compiler errors

[wookayin]

Problem: The code can't build with modern versions of gcc and clang due to compiler errors (e.g., especially on arm64 macOS).

Mainly there are three issues:

• error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]

• error: incompatible pointer to integer conversion passing 'unsigned short *' to parameter of type 'unsigned short'; remove & [-Wint-conversion]

• error: incompatible function pointer types initializing 'char **(*)(int *)' with an expression of type 'zword *(int *)' (aka 'unsigned short *(int *)') [-Wincompatible-function-pointer-types]

Solution:

• Fix obvious mistakes in the function declaration.
• Use the correct type.

[wookayin]

@microsoft-github-policy-service agree

[MarcCote]

That is great. I'll check it out and make all tests pass and that everything is fine with other build environments.

[MarcCote]

@wookayin can you tell me which version of gcc and clang you are using? The compilation seems to be passing (granted with a lot of warnings) on this runner (macos14-arm64) https://github.com/microsoft/jericho/actions/runs/8853947959/job/24315904384?pr=71

[wookayin]

In one of my environments:

$ which -a gcc clang

gcc: aliased to nocorrect gcc
/usr/bin/gcc
/usr/bin/clang

$ gcc --version       # or clang --version too

Apple clang version 15.0.0 (clang-1500.3.9.4)
Target: arm64-apple-darwin23.4.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

macOS 14.4.1 (23E224), XCode 15.3. I didn't have the CC or CFLAGS env variables set.

[MarcCote]

Thanks again. Will make a new release tomorrow.