search

microsoft / jericho

A learning environment for man-made Interactive Fiction games.
GNU General Public License v2.0
257 stars 42 forks source link

defines to alloc.h #7

Closed monuelo closed 5 years ago

monuelo commented 5 years ago

define malloc, realloc, free and memcpy as farmalloc, farrealloc, farfree and _fmemcpy, respectively.

mhauskn commented 5 years ago

Hi @hericlesme can you comment on the motivation for this PR?

monuelo commented 5 years ago

In other files where the alloc.h header is used, these are defined, as in fastmem.c, quetzal.c, squetzal.c... I thought that standardizing this would be good. I sent the change in the first file, but I've noticed that more files in the same folder do not have these defines. I can do it if you want.

MarcCote commented 5 years ago

Unless there is a bug in Jericho, it might be better to submit those changes to the original frotz repository (https://gitlab.com/DavidGriffith/frotz). What do you think?

monuelo commented 5 years ago

@MarcCote It's fine by me.

MarcCote commented 5 years ago

I'll let @mhauskn call the shot. In any case, thanks for using Jericho. Let us know if you have any issue with the framework.

monuelo commented 5 years ago

I have no problems. I was only interested in OpenSource projects and I'm looking for ways to contribute to the community. Anyway, thank you! :nerd_face:

mhauskn commented 5 years ago

I think this would be better sent to the Frotz repository. Thanks for submitting though.