microsoft / jupyter-Kqlmagic

Extension (Magic) to Jupyter notebook and Jupyter lab, that enable notebook experience working with Kusto, ApplicationInsights, and LogAnalytics data.
Other
85 stars 31 forks source link

"popup schema" button doesn't work when path has spaces #15

Closed jruales closed 5 years ago

jruales commented 5 years ago

When running a notebook that is located in a file path that has spaces in it, the temporary html files that are generated with the table schema have the spaces replaced with underscores. However, when clicking on the "popup schema" button, the URL that is generated doesn't have the replacement of spaces to underscores, so this causes a 404 page to be displayed.

mbnshtck commented 5 years ago

thx, for letting me know about this issue. will fix it. Michael

Michael


From: Joaquín Ruales notifications@github.com Sent: Thursday, June 27, 2019 3:49:48 AM To: microsoft/jupyter-Kqlmagic Cc: Subscribed Subject: [microsoft/jupyter-Kqlmagic] "popup schema" button doesn't work when path has spaces (#15)

When running a notebook that is located in a file path that has spaces in it, the temporary html files that are generated with the table schema have the spaces replaced with underscores. However, when clicking on the "popup schema" button, the URL that is generated doesn't have the replacement of spaces to underscores, so this causes a 404 page to be displayed.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fjupyter-Kqlmagic%2Fissues%2F15%3Femail_source%3Dnotifications%26email_token%3DACGKLXTMBCRLDBB2EB5AVBTP4QFCZA5CNFSM4H3XEHDKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G36CBLA&data=02%7C01%7Cmichabin%40microsoft.com%7Cad59578b0fc9470ca78108d6fa995b46%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636971933906051353&sdata=4xQCywwSlf7%2FJltPDzf3rfcxWzzHnE24OVk04k2N70o%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACGKLXVCPZZDJONSDVWQHJLP4QFCZANCNFSM4H3XEHDA&data=02%7C01%7Cmichabin%40microsoft.com%7Cad59578b0fc9470ca78108d6fa995b46%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636971933906061365&sdata=3nNK739ISWvC3rnywgdoXbOCzcvV%2Bhve8cMp3zuRcNo%3D&reserved=0.

mbnshtck commented 5 years ago

resolved in version 0.1.106