search

microsoft / jupyter-Kqlmagic

Extension (Magic) to Jupyter notebook and Jupyter lab, that enable notebook experience working with Kusto, ApplicationInsights, and LogAnalytics data.
Other
85 stars 31 forks source link

Incorrect html escaping of info messages #16

Closed jruales closed 5 years ago

jruales commented 5 years ago

In this line: https://github.com/microsoft/jupyter-Kqlmagic/blob/4e5dce7911fcdc90eff72fdfc7aa0fa9494af92c/azure/Kqlmagic/display.py#L270

the .replace(" ", "&nbsp") is missing a semicolon after the nbsp.

jruales commented 5 years ago

The issue is clearly visible when we run a notebook using Papermill: PapermillOutput

mbnshtck commented 5 years ago

thanks, will fix shortly. BTW, working on support for papermill, will be deployed end of next week.

jruales commented 5 years ago

This issue was already fixed with PR #18 .

Regarding papermill support: nice! Although I wonder what exactly this support will entail, since we can already run notebooks with Kql from papermill? Will it allow passing the connection string from papermill directly? Currently we've been using a workaround where we inject a %run magic at the start of the notebook to initialize Kqlmagic with a connection string (that we have in a separate notebook), before running the notebook. We also disable the pretty html errors so that we have the errors as exceptions when run the notebook with papermill