microsoft / jupyter-Kqlmagic

Extension (Magic) to Jupyter notebook and Jupyter lab, that enable notebook experience working with Kusto, ApplicationInsights, and LogAnalytics data.
Other
85 stars 31 forks source link

Add undeclared import dependency on azure-common pkg to setup.py #61

Open alexkyllo opened 4 years ago

alexkyllo commented 4 years ago

This PR is to resolve #60 which is caused by a ModuleNotFoundError: No module named 'azure.common' that throws at this line when the user tries to utilize the -try-azcli-login connection string option. Adding azure-common as a dependency in setup.py resolves the error.

https://github.com/microsoft/jupyter-Kqlmagic/blob/55770382a2a527d852481b3b65a3ec07ce2d0167/azure/Kqlmagic/my_aad_helper.py#L635

mbnshtck commented 4 years ago

will be fixed in next version