search

microsoft / jupyter-Kqlmagic

Extension (Magic) to Jupyter notebook and Jupyter lab, that enable notebook experience working with Kusto, ApplicationInsights, and LogAnalytics data.
Other
85 stars 31 forks source link

Kqlmagic references FilesServerManagement._pid before it is set in FilesServerManagagement.__init__ #91

Closed David-Noble-at-work closed 2 years ago

David-Noble-at-work commented 2 years ago

See my_files_server_management.py, on or about lines 45-46:

        self._liveness_mode = self._find_liveness_mode(sys.platform)
        self._pid = os.getpid()

Notice that on non-Windows platforms that self._pid is referenced by self._find_liveness_mode.

David-Noble-at-work commented 2 years ago

Are you guys actively looking at issues? I'm Microsoft and available for a remote debugging session on macOS, if you would like. It seems to me you've let some Window-isms creep in. You also don't work very well with JetBrains. I'm here to help, if you'd like.

mbnshtck commented 2 years ago

will be fixed in next update

David-Noble-at-work commented 2 years ago

@mbnshtck I just picked up Kqlmagic-0.1.114.post17. Is this fixed in the release following it? Here's the error on macOS:

AttributeError: 'FilesServerManagement' object has no attribute '_pid'

The fix as you know is simple.