search

microsoft / jupyter-core

Library for writing Jupyter kernels in .NET Core
MIT License
108 stars 23 forks source link

Fix metadata #93

Closed cgranade closed 2 years ago

cgranade commented 2 years ago

This PR ensures that metadata in messages and display data are always well-formed JSON objects, rather than null or string-valued.

anpaz commented 2 years ago

/azp run

azure-pipelines[bot] commented 2 years ago
Azure Pipelines successfully started running 1 pipeline(s).
cgranade commented 2 years ago

Changes lgtm. This is probably a breaking change (due to the change in the Metadata signature) so we should probably upgrade the build major too.

Thanks for your review! Agreed about updating the version number, I hadn't thought of it as breaking but you're absolutely right. Thanks for catching that!

cgranade commented 2 years ago

Merging as signed pipeline has passed.