search

microsoft / just

The task library that just works
https://microsoft.github.io/just
MIT License
1.95k stars 92 forks source link

Include onCompile in filtered out object keys for webpack task #685

Closed rlandav closed 1 year ago

rlandav commented 1 year ago

Overview

When specifying the onCompile callback, the webpack task would fail with the error that the onCompile key is not a valid webpack configuration value. This was occurring because the webpack task options are merged into the webpack configuration by default, with only a few keys excluded.

This change also excludes the onCompile key so that a caller can specify it.

Test Notes

Validated this in a separate project which leverages just.

rlandav commented 1 year ago

@kenotron could I get a review on this PR?