search

microsoft / kafka-connect-cosmosdb

Kafka Connect connectors for Azure Cosmos DB
MIT License
48 stars 54 forks source link

Boolean default values don't show up properly Control-center #307

Closed sivamu closed 3 years ago

sivamu commented 3 years ago

Description

The boolean default config values show up as "true" even when "false" is specified as a default.

image

kev-ms commented 3 years ago

This bug seems to be on kafka config class. Observed similar behavior in other connectors' config as well as default error configs with Boolean type.

Possible workaround could be configuring field as String instead of Boolean, that would convert config dropdown to free text box on control center UI.

brandynbrown commented 3 years ago

@kev-ms to your point, that would kind of defeat the purpose. I am going to put this in the handoff epic to be discussed with the PG.

ryancrawcour commented 3 years ago

Sounds like a bug on Kafka side. Not cosmos side.

From: Brandy notifications@github.com Sent: Thursday, 4 February 2021 12:14 To: microsoft/kafka-connect-cosmosdb Cc: Subscribed Subject: Re: [microsoft/kafka-connect-cosmosdb] Boolean default values don't show up properly Control-center (#307)

@kev-mshttps://github.com/kev-ms to your point, that would kind of defeat the purpose. I am going to put this in the handoff epic to be discussed with the PG.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/microsoft/kafka-connect-cosmosdb/issues/307#issuecomment-772891626, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJI62VKVMTGCCY7GL3TYUV3S5HKDTANCNFSM4W7RB7BQ.

ryancrawcour commented 3 years ago

They did say somewhere in their docs to not use boolean but instead use an array of supported values ... In our case yes/no or true/false or "enabled/disabled"

Can't remember where in the docs it gives an example of this. Perhaps in the Checklist doc linked in the project?

From: kev-ms notifications@github.com Sent: Thursday, 4 February 2021 09:25 To: microsoft/kafka-connect-cosmosdb Cc: Subscribed Subject: Re: [microsoft/kafka-connect-cosmosdb] Boolean default values don't show up properly Control-center (#307)

This bug seems to be on kafka config class. Observed similar behavior in other connectors' config as well as default error configs with Boolean type.

Possible workaround could be configuring field as String instead of Boolean, that would convert config dropdown to free text box.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/microsoft/kafka-connect-cosmosdb/issues/307#issuecomment-772798981, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJI62VPSHDIHAEOQ6P7SHO3S5GWL7ANCNFSM4W7RB7BQ.

brandynbrown commented 3 years ago

@kev-ms should we explore Ryan's suggestion in M2?

kev-ms commented 3 years ago

Yes, we should look in to those alternatives

brandynbrown commented 3 years ago

The consensus was to fix this by not using booleans as that is what's noted in the docs.