search

microsoft / kernel-memory

RAG architecture: index and query any data using LLM and natural language, track sources, show citations, asynchronous memory patterns.
https://microsoft.github.io/kernel-memory
MIT License
1.35k stars 252 forks source link

Alef/simplifynugets #469

Closed afederici75 closed 2 months ago

afederici75 commented 2 months ago

Motivation and Context (Why the change? What's the scenario?)

Here's the new PR with the additional tests I could not easily port yesterday. I had to touch the Elasticsearch project, but there shouldn't be any conflict. I am not sure why it says it cannot merge automatically.... Details below.

High level description (Approach, Design)

Changes in Elasticsearch:

-Removed all Free Mind Labs, Inc. copyright in both extension and test project.
-Refactored IndexNameHelper and turned it into a static class. This removed a lot of unnecessary complexity and arguments.
-Adjusted ElasticsearchMemoryDb to the changes in IndexNameHelper.

Elasticsearch.UnitTests

-Removed Usings.cs
-Created MemoryDbFunctionalTest which descends from KM's BaseFunctionalTestCase, thus providing access to configuration and other common things.
-Refactored all tests to inherit from MemoryDbFunctionalTest and be consitent with KM's.

All Elasticsearch tests pass: -DefaultTests (11) -Additional (35)

afederici75 commented 2 months ago

I am going to merge this into the current main and then post a new PR for this.