microsoft / kernel-memory

RAG architecture: index and query any data using LLM and natural language, track sources, show citations, asynchronous memory patterns.
https://microsoft.github.io/kernel-memory
MIT License
1.52k stars 293 forks source link

Add batch upsert support for SQL Server Memory DB #489

Closed kbeaugrand closed 4 months ago

kbeaugrand commented 4 months ago

Related to #485

Implements batching upsert functionality in SQL Server Memory DB and updates documentation to reflect the new feature.


For more details, open the Copilot Workspace session.

dluc commented 4 months ago

@kbeaugrand:

Error: SqlServerMemory.cs(377,43): error CS8425: Async-iterator 'SqlServerMemory.BatchUpsertAsync(string, IEnumerable, CancellationToken)' has one or more parameters of type 'CancellationToken' but none of them is decorated with the 'EnumeratorCancellation' attribute, so the cancellation token parameter from the generated 'IAsyncEnumerable<>.GetAsyncEnumerator' will be unconsumed [/home/runner/work/kernel-memory/kernel-memory/extensions/SQLServer/SQLServer/SQLServer.csproj]

https://github.com/microsoft/kernel-memory/actions/runs/9132504455/job/25113991349?pr=489

kbeaugrand commented 4 months ago

@kbeaugrand:

Error: SqlServerMemory.cs(377,43): error CS8425: Async-iterator 'SqlServerMemory.BatchUpsertAsync(string, IEnumerable, CancellationToken)' has one or more parameters of type 'CancellationToken' but none of them is decorated with the 'EnumeratorCancellation' attribute, so the cancellation token parameter from the generated 'IAsyncEnumerable<>.GetAsyncEnumerator' will be unconsumed [/home/runner/work/kernel-memory/kernel-memory/extensions/SQLServer/SQLServer/SQLServer.csproj]

https://github.com/microsoft/kernel-memory/actions/runs/9132504455/job/25113991349?pr=489

Should be fixed now.