Closed afederici75 closed 1 month ago
Sorry I'm still unable to make changes to the PR for some reason, I don't know why. I just tried to push fixes to indentation and removing unused imports, but instead of updating the PR github created a new branch. This is the same approach I used with other PRs, I don't know what's different with this one.
You can see my commit on your repo at https://github.com/freemindlabsinc/kernel-memory/compare/elasticsearch_latest...microsoft%3Akernel-memory%3Aelasticsearch_latest, but the commit is not propagating to the PR
I'll reuse the workaround of having a temporary dev branch, merging this PR into dev, and then fixing dev, and merging dev into main.
Motivation and Context (Why the change? What's the scenario?)
-Ported additional tests from FML's original repo -Added Elasticsearch support for TestMemoryFilters and TestCosineSimilarity
High level description (Approach, Design)
Changes in Elasticsearch:
Elasticsearch.UnitTests
All Elasticsearch tests pass: -DefaultTests (11) -Additional (35)
Microsoft.KM.Core.Functional.... tests pass: -TestMemoryFilters -TestCosineSimilarity