Closed MartinM85 closed 3 months ago
I've made changes in kiota-serialization-json-dotnet, but need to reference kiota-abstractions-dotnet 1.7.6 before creating a pull request.
Suppose that at the end, the SDK generator will generate something like this
public class WorkbookFilterCriteria : IAdditionalDataHolder, IBackedModel, IParsable {
...
public UntypedNode? Values {
get { return BackingStore?.Get<UntypedNode?>("values"); }
set { BackingStore?.Set("values", value); }
}
...
public virtual IDictionary<string, Action<IParseNode>> GetFieldDeserializers() {
return new Dictionary<string, Action<IParseNode>> {
...
{"values", n => { Values = n.GetUntypedValue(); } },
};
}
public virtual void Serialize(ISerializationWriter writer) {
_ = writer ?? throw new ArgumentNullException(nameof(writer));
...
writer.WriteUntypedValue("values", Values);
writer.WriteAdditionalData(AdditionalData);
}
}
instead of the current:
public class WorkbookFilterCriteria : IAdditionalDataHolder, IBackedModel, IParsable {
...
public Json? Values {
get { return BackingStore?.Get<Json?>("values"); }
set { BackingStore?.Set("values", value); }
}
...
public virtual IDictionary<string, Action<IParseNode>> GetFieldDeserializers() {
return new Dictionary<string, Action<IParseNode>> {
...
{"values", n => { Values = n.GetObjectValue<Json>(Json.CreateFromDiscriminatorValue); } },
};
}
public virtual void Serialize(ISerializationWriter writer) {
_ = writer ?? throw new ArgumentNullException(nameof(writer));
...
writer.WriteObjectValue<Json>("values", Values);
writer.WriteAdditionalData(AdditionalData);
}
}
This pull request has conflicting changes, the author must resolve the conflicts before this pull request can be merged.
Conflicts have been resolved. A maintainer will take a look shortly.
This pull request has conflicting changes, the author must resolve the conflicts before this pull request can be merged.
Conflicts have been resolved. A maintainer will take a look shortly.
This pull request has conflicting changes, the author must resolve the conflicts before this pull request can be merged.
Just as an update to anyone watching this: we're finalizing the work on the other main languages before we merge everything in. Thank you for your patience :)
Closes #175