microsoft / kiota-abstractions-dotnet

Abstractions library for the Kiota generated SDKs in dotnet
https://aka.ms/kiota/docs
MIT License
24 stars 21 forks source link

Remove System.Diagnostics.DiagnosticSource dependency from net 6+ #218

Closed thompson-tomo closed 2 months ago

thompson-tomo commented 2 months ago

Is your feature request related to a problem? Please describe. I want to minimise dependencies in my project by utilising framework dependencies wherever possible

Describe the solution you'd like I want the package to not have an explicit dependency on System.Diagnostics.DiagnosticSource on net 6+.

Describe alternatives you've considered Accept the additional dependency

Additional context n/a

andrueastman commented 2 months ago

Thanks for raising this @thompson-tomo

Would you be willing to submit a PR similar to https://github.com/microsoft/kiota-abstractions-dotnet/issues/219 for this?

thompson-tomo commented 2 months ago

@andrueastman sure I will go through submitting PR's in the coming days.

thompson-tomo commented 2 months ago

Submitted as #220