microsoft / kiota-abstractions-dotnet

Abstractions library for the Kiota generated SDKs in dotnet
https://aka.ms/kiota/docs
MIT License
24 stars 21 forks source link

Helper for parsing enums from string #259

Closed MartinM85 closed 29 minutes ago

MartinM85 commented 1 week ago

Closes #258

Generic method is same as the current method implemented in https://github.com/microsoft/kiota-serialization-json-dotnet/blob/d0454daecb7ec2327f3e55d642fa510cf617e8b5/src/JsonParseNode.cs#L214

MartinM85 commented 1 day ago

This looks good to me.

@MartinM85 Any chance you were looking to update microsoft/kiota-http-dotnet#266 with a local reference of this PR first to validate the changes here before we merge?

Confirmed...with a local reference of Kiota.Abstractions and enum helper called from SendPrimitiveAsync, the tests added in microsoft/kiota-http-dotnet#266 passed