search

microsoft / kiota-abstractions-ruby

Abstractions library for the Kiota generated SDKs in Ruby
https://aka.ms/kiota/docs
MIT License
2 stars 4 forks source link

Switch to std-uritemplate #16

Closed andreaTP closed 1 year ago

andreaTP commented 1 year ago

Fix #15

baywet commented 1 year ago

@andreaTP thanks for the contribution as always!

baywet commented 1 year ago

@andreaTP there might be issues with the packaging, see the CI failures for ubuntu

andreaTP commented 1 year ago

Let me check 👍

andreaTP commented 1 year ago

I can reproduce the issue on Ubuntu, but I'm a bit lost, as the same commands are working on OsX 😞

If anyone with some Ruby expertise would like to point me in a direction I'll be happy to follow, otherwise, I'll keep digging tomorrow.

baywet commented 1 year ago

I've tried looking into it for the past hour, but I'm not super pro-efficient with ruby. As far as I know bundle exec restricts the context and access to global gems. But from my understanding, this shouldn't be an issue in our case. I can see you've already looked into caching. I'm not sure how even the first commit could have a cache hit (but then again, so does MacOS), maybe it's because the Gemfile.lock is NOT present?. Also it seems to work fine on windows.

andreaTP commented 1 year ago

Thanks a lot @baywet for the effort in looking into this, I'll go in the rabbit hole tomorrow, possibly asking on some Ruby channels.

Super interesting that it's working on Win as well!

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

andreaTP commented 1 year ago

The issue is fixed and the tests are green on my fork: https://github.com/andreaTP/kiota-abstractions-ruby/actions/runs/6096274750/job/16541591070

baywet commented 1 year ago

Hum... I guess this was the issue

https://github.com/std-uritemplate/std-uritemplate/compare/0.0.38...0.0.39#diff-7708a3635247efbf999cce5719387062c6ff1031150685d5e54bf7a3d24b1859L6

andreaTP commented 1 year ago

what was the issue at then end of the day?

I'm convinced it was the casing of the filename ... Since I was at it I improved the overall package information etc.