search

microsoft / kiota-dotnet

Abstractions library for the Kiota generated SDKs in dotnet
https://aka.ms/kiota/docs
MIT License
40 stars 34 forks source link

Added Non-Generic Solution to KiotaDeserialization #436

Closed DerGuru closed 1 month ago

DerGuru commented 1 month ago

This code addition fulfills the request of Issue 210, where this was explicitly requested.

@dansmitt is a co-worker of mine and I thought, that this might be of relevance to more than just him.

I used the same Unit-Tests, as you were, modifying them just as much, to use the newly introduced method signatures.

DerGuru commented 1 month ago

Okay .. @baywet I took your comments to heart and split the base class into a factory and an interface. I also hope to have fixed the whitespace issue.... weirdly, that was auto generated code...

I was also able, to remove the #pragma warning disable IL3050, which just needed some attributes added to the code. And since I don't like to have pre compiler directives spread all over the code, I added the Attribute as a privately nested class, for .NET < 8. I hope, that is okay.