microsoft / kiota-http-ruby

Kiota http provider implementation for Ruby with Faraday
https://aka.ms/kiota/docs
MIT License
13 stars 3 forks source link

Make sure the base url is set when calling authenticate_request #27

Closed louim closed 9 months ago

louim commented 9 months ago

This is a fix for the issue where the base url was not being set when calling authenticate_request.It caused an error later in the microsoft_kiota_authentication_oauth gem. The crux of the problem goes like that:

The fix is to always make sure we set the baseurl before calling action where the url might be templated. The fix is inspired from the Csharp version of the class.

I tried adding some kind of test, but there almost nothing already in place and to test my small fix, I would have to either mock or instantiate a dozen of classes which some are not even in the same gem 😢.

sonarcloud[bot] commented 9 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

louim commented 9 months ago

@rkodev I pushed commit containing the version bump/changelog. @baywet you said to bump the patch, but I assume you meant the minor since the gem is in initial developement. Let me know if that's ok.