Closed Acurisu closed 1 month ago
@microsoft-github-policy-service agree
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
On the topic of making methods private so noone takes a dependency on it as they are unique for the JSON serializer. Shouldn't write_any_value
also be private?
And I chose to make the methods "private" now using __
so they are really mangled, but would you prefer them being "semiprivate" like the other methods such as _serialize_value
instead?
@Acurisu linting is failing, and I don't have permissions to push to your fork. Can you apply the following patch on your end please? 0001-chore-linting-fixes.patch
On the topic of making methods private so noone takes a dependency on it as they are unique for the JSON serializer. Shouldn't
write_any_value
also be private?
Yes I guess it should have been since it's not in the interface. However changing it now would be a source breaking change. SO let's leave it as is.
And I chose to make the methods "private" now using
__
so they are really mangled, but would you prefer them being "semiprivate" like the other methods such as_serialize_value
instead?
Private is fine, if we get feedback people need to access those methods for some reason, we can always relax things later.
@Acurisu linting is failing, and I don't have permissions to push to your fork. Can you apply the following patch on your end please?
Will do so. Seems like the linter config didn't get applied on my end, my bad.
actually hold on, I'm going to make the changes on my end since this is blocking a few things here. Sorry about the confusion.
Overview
Several classes contain
dict[str, Any]
or evenlist[dict[str, Any]]
inside theiradditional_data
which is currently not handled.Related Issue
~
Demo
~
Notes
As I'm unsure about certain design decision this might not be the intended way of solving this. Since I only tested this in the cases where it affects me it might not cover all cases.
Testing Instructions
CanvasLayout
which contains bothdict[str, Any]
andlist[dict[str, Any]]
and compare to the original object.