fix: get_datetime_value fails to serialize empty string

pjmagee commented 4 months ago

In the ISO 8601 date format (YYYY-MM-DD), the shortest possible valid date string is 10 characters long. Therefore, if the length of the string is less than 10, it cannot be a valid date in this format, and the function can immediately return None without attempting to parse the date, which would be a more expensive operation.

Overview

Brief description of what this PR does, and why it is needed.

Related Issue

Fixes #258

Demo

Optional. Screenshots, curl examples, etc.

Notes

Optional. Ancillary topics, caveats, alternative strategies that didn't work out, anything else.

Testing Instructions

How to test this PR
Prefer bulleted description
Start after checking out this branch
Include any setup required, such as bundling scripts, restarting services, etc.
Include test case, and expected output

pjmagee commented 4 months ago

Also wondering, instead of trying to be optimal here with datetime, maybe a try/exception implementation for all the pendulum parsing should happen, and if it works, the type is returned, otherwise None is returned?