search

microsoft / kiota-serialization-json-ruby

Kiota serialization provider implementation for Ruby and JSON
https://aka.ms/kiota/docs
MIT License
1 stars 4 forks source link

fix setting root element and don't return empty values #28

Open olafura opened 7 months ago

olafura commented 7 months ago

When setting the root we don't seem to be setting it to the writer so when we call get_serialized_content we don't get anything.

Also the ms graph api doesn't like empty values so I clean them up before returning.

baywet commented 7 months ago

@olafura the unit tests seem to be failing with this change, can you look into it please? Also don't forget to sign the CLA (see the bot comment)

sonarcloud[bot] commented 7 months ago

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

olafura commented 7 months ago

@microsoft-github-policy-service agree