microsoft / kiota-typescript

TypeScript libraries for Kiota-generated API clients.
https://aka.ms/kiota/docs
MIT License
34 stars 25 forks source link

ensure 3XX responses without location header do not throw #1119

Open baywet opened 5 months ago

baywet commented 5 months ago

follow up to https://github.com/microsoft/kiota/pull/4367 and https://github.com/microsoft/kiota/issues/4190

Implement a unit test with a 304 response, no location header, check the request adapter returns null and doesn't throw. Most likely this line will need to be adapted. https://github.com/microsoft/kiota-typescript/blob/985036391e8a9823e363f5c2fde486ae9186ea0a/packages/http/fetch/src/fetchRequestAdapter.ts#L387C9-L387C20

harshav1989 commented 1 month ago

id like to do this can u pls assign me

baywet commented 1 month ago

Done! Let us know if you have questions.

harshav1989 commented 1 month ago

yup!