search

microsoft / kiota

OpenAPI based HTTP Client code generator
https://aka.ms/kiota/docs
MIT License
2.83k stars 194 forks source link

`kiota info -l TypeScript` should not automatically emit the `kiota-authentication-azure` package #3019

Open sebastienlevert opened 1 year ago

sebastienlevert commented 1 year ago

Based on my experience, adding this package to all apps being build is not necessary. Do we have a way to identify that azure identity is required? I feel it bloats an app that doesn't rely on azure.

Generation

kiota generate -l typescript -o generated -d https://raw.githubusercontent.com/nytimes/public_api_specs/master/movie_reviews/movie_reviews_v2.json -c NytMovieClient -n Nyt

Information

kiota info -l TypeScript

The language TypeScript is currently in Experimental maturity level.
After generating code for this language, you need to install the following packages:
npm install @microsoft/kiota-abstractions@1.0.0-preview.22 -S
npm install @microsoft/kiota-http-fetchlibrary@1.0.0-preview.21 -S
npm install @microsoft/kiota-serialization-form@1.0.0-preview.11 -S
npm install @microsoft/kiota-serialization-json@1.0.0-preview.20 -S
npm install @microsoft/kiota-authentication-azure@1.0.0-preview.17 -S
npm install @microsoft/kiota-serialization-text@1.0.0-preview.19 -S

Thoughts on this @baywet and @koros?

baywet commented 1 year ago

This is where I think we could improve the experience by making a difference between required and optional packages. What do you think? I'd like @RabebOthmani to flesh out the experience of the command and the tab in vs code. We could alternatively, or additionally, categorize dependencies (required, http, serialization, authentication), and/or add one liner descriptions.

baywet commented 4 months ago

moving this back to the backlog until we get a spec from @sebastienlevert on the issue