1.5.0 generates broken CLI request builder

[jasonjoh]

In 1.5, kiota generates a request builder for the quickstart that will not compile.

\kiota-samples\get-started\quickstart\cli\src\Client\Posts\PostsRequestBuilder.cs(24,63): error CS0161: 'Posts
RequestBuilder.this[string].get': not all code paths return a value [C:\Source\Repos\kiota-samples\get-started\quickstart\cli
\src\KiotaPostsCLI.csproj]

Offending code:

[Obsolete("This indexer is deprecated and will be removed in the next major version. Use the one with the typed parameter instead.")]
public PostItemRequestBuilder this[string position] { get {
    var urlTplParams = new Dictionary<string, object>(PathParameters);
    if (!string.IsNullOrWhiteSpace(position)) urlTplParams.Add("post%2Did", position);
} }

This method wasn't present at all in the 1.4 generated client, and I verified that removing it fixes the issue (and the client still works).

[baywet]

This seems to be a side effect of #3058. We should probably add a refiner method for CLI that removes those backward compatible indexers. @calebkiage do you need indexers at all in the CLI generation?

[baywet]

put together #3091

[calebkiage]

Hey @bawet, I do use indexers but in a different way than C#. I create a list of commands whenever I encounter an indexer. See https://github.com/microsoft/kiota/blob/main/src/Kiota.Builder/Writers/CLI/CliCodeMethodWriter.cs#L65

[calebkiage]

Are these indexers duplicates?

[baywet]

Thanks for the additional context. Yes we now have 2 indexers in some cases to avoid breaking binary compatibility in CSharp. One with the specific type, and another still with string and tagged as obsolete.