microsoft / kiota

OpenAPI based HTTP Client code generator
https://aka.ms/kiota/docs
MIT License
2.89k stars 200 forks source link

Intergration tests `it/generate-code.ps1` does not fail if kiota generation fails. #4028

Closed andrueastman closed 8 months ago

andrueastman commented 8 months ago

Taking a look at the run at https://github.com/microsoft/kiota/actions/runs/7574601239/job/20646087900?pr=4027

The intergration tests for https://developers.pipedrive.com/docs/api/v1/openapi.yaml fail due to a a bad description. However the tests do not error out at this stage but continue to try to compile build a project with no generated code leading to a false positive.

We should

baywet commented 8 months ago

interestingly enough, there are suppressions for that API, but not for Java https://github.com/microsoft/kiota/blob/8f5d3b8fcb950bd6606c7ef04c71355a7de7c278/it/config.json#L120

The parsing issue is most likely caused by the fact this API has ambiguous path items (/foo/bar and /foo/{bar})

andrueastman commented 8 months ago

The description indeed has the duplicate paths as /oauth/token/ and /oauth/token. Authored https://github.com/microsoft/kiota/pull/4040 to resolve by adding an exclusion for the path.